Skip to content

Fix test_asyncio for windows#6959

Merged
youknowone merged 3 commits intoRustPython:mainfrom
youknowone:asyncio
Feb 2, 2026
Merged

Fix test_asyncio for windows#6959
youknowone merged 3 commits intoRustPython:mainfrom
youknowone:asyncio

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Feb 2, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Tests

    • Expanded test coverage on Windows platform by enabling previously skipped tests.

  • Bug Fixes

    • Improved exception handler cleanup logic to properly manage named exception variables during unwinding, enhancing error handling reliability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This pull request makes two distinct changes: removing test_asyncio from the Windows test skip list in CI configuration, and augmenting exception handler cleanup block generation in the codegen compiler to carry exception name data for named exception handlers.

Changes

Cohort / File(s) Summary
CI Configuration
.github/workflows/ci.yaml		 Removed test_asyncio from Windows-specific test skip list (WINDOWS_SKIPS), expanding the set of tests run on Windows platform.
Exception Handler Cleanup
crates/codegen/src/compile.rs		 Replaced two push_fblock calls with push_fblock_full for HandlerCleanup fblocks, adding FBlockDatum parameter to carry exception name context. Passes FBlockDatum::ExceptionName(name) for named handlers and FBlockDatum::None for unnamed handlers.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly Related PRs

Poem

🐰 A rabbit hops through cleanup blocks,
Exception names in data locks,
Windows tests now run with glee,
No more skips on asyncio spree!
Handlers whisper secrets clear, ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix test_asyncio for windows' aligns with the main change shown in the raw summary: removing test_asyncio from WINDOWS_SKIPS in .github/workflows/ci.yaml to fix its execution on Windows.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Code has been automatically formatted

The code in this PR has been formatted using:

  • cargo fmt --all
    Please pull the latest changes before pushing again:
git pull origin asyncio

@youknowone youknowone marked this pull request as ready for review February 2, 2026 06:43
@youknowone youknowone merged commit f7b2660 into RustPython:main Feb 2, 2026
12 of 13 checks passed
@youknowone youknowone deleted the asyncio branch February 2, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone