automark add reasons to reason-less expectedFailures and handles parent better#6936
automark add reasons to reason-less expectedFailures and handles parent better#6936youknowone merged 4 commits intoRustPython:mainfrom
Conversation
📝 WalkthroughWalkthroughThis PR enhances test failure marking with inheritance-aware handling, allowing parent class test markers to be set when all child inheritors fail, and enabling stripping of unreasoned failure decorators. It includes a minor formatting adjustment to a Rust debug assertion and comprehensive test updates. Changes
Sequence DiagramsequenceDiagram
participant FileSystem as File System
participant AutoMark as Auto-Mark Engine
participant CodeAnalysis as Code Analysis
participant TestRunner as Test Runner
participant Consolidator as Consolidator
FileSystem->>AutoMark: Load test file
AutoMark->>AutoMark: Strip reasonless `@expectedFailure` decorators
AutoMark->>FileSystem: Write modified file
AutoMark->>TestRunner: Run tests
TestRunner->>TestRunner: Collect failures (parent & child classes)
TestRunner->>AutoMark: Return failing tests
AutoMark->>CodeAnalysis: Expand stripped markers to inheritors
CodeAnalysis->>CodeAnalysis: Find all classes inheriting methods
CodeAnalysis->>AutoMark: Return expanded failure set
AutoMark->>Consolidator: Attempt consolidation
Consolidator->>Consolidator: Check if all inheritors failed
Consolidator->>Consolidator: Consolidate to parent class
Consolidator->>AutoMark: Return consolidated failures
AutoMark->>FileSystem: Apply `@expectedFailure` markers
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code has been automatically formatted The code in this PR has been formatted using:
git pull origin auto-mark |
Summary by CodeRabbit
Style
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.