Skip to content

Remove RustPython-specific workaround in timeit module#6923

Merged
youknowone merged 1 commit intoRustPython:mainfrom
moreal:update-3.14.2-timeit
Feb 1, 2026
Merged

Remove RustPython-specific workaround in timeit module#6923
youknowone merged 1 commit intoRustPython:mainfrom
moreal:update-3.14.2-timeit

Conversation

@moreal
Copy link
Contributor

@moreal moreal commented Feb 1, 2026 •
edited
Loading

XXX: RUSTPYTHON comment might be removed by implementing gc module in #6910.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 1, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Lib/timeit.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fanninpm fanninpm mentioned this pull request Feb 1, 2026
Open
@moreal
Copy link
Contributor Author

moreal commented Feb 1, 2026

The timeit module is already upgraded by #6854. This pull request will remove only RustPython-specific workaround thanks to #6910.

@moreal moreal changed the title Update timeit from v3.14.2 Remove RustPython-specific workaround in timeit module Feb 1, 2026
@moreal moreal force-pushed the update-3.14.2-timeit branch from c6aea09 to f29131b Compare February 1, 2026 02:02
@moreal moreal self-assigned this Feb 1, 2026
@moreal moreal force-pushed the update-3.14.2-timeit branch from f29131b to 434296d Compare February 1, 2026 04:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/timeit.py
[x] test: cpython/Lib/test/test_timeit.py

dependencies:

  • timeit

dependent tests: (1 tests)

  • timeit: test_timeit

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@moreal moreal marked this pull request as ready for review February 1, 2026 05:22
@youknowone youknowone merged commit c6f7c6e into RustPython:main Feb 1, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

@moreal moreal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moreal @youknowone