Skip to content

init warnings before site#6771

Merged
youknowone merged 1 commit intoRustPython:mainfrom
youknowone:init-warning
Jan 18, 2026
Merged

init warnings before site#6771
youknowone merged 1 commit intoRustPython:mainfrom
youknowone:init-warning

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Jan 18, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Optimized the startup sequence to eliminate redundant initialization code while maintaining the same functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The run_rustpython function is refactored to move the warnings module initialization block earlier in the startup sequence, immediately after creating the new scope. A duplicate initialization block that previously appeared after the site import is removed, eliminating the redundant import attempt.

Changes

Cohort / File(s) Summary
Warnings module initialization reordering
src/lib.rs		 Moved the warnings module import initialization to execute immediately after scope creation instead of after site import; removed duplicate initialization block that appeared later in the startup sequence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • fanninpm

Poem

🐰 A hop and a shuffle, the warnings now lead,
Early in startup, they take their own seed,
No duplication to clutter the way,
Cleaner and swifter, a better today! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'init warnings before site' directly and clearly describes the main change: moving warnings module initialization before site import.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone marked this pull request as ready for review January 18, 2026 09:45
@youknowone youknowone merged commit e8dd582 into RustPython:main Jan 18, 2026
13 checks passed
@youknowone youknowone deleted the init-warning branch January 18, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone