increase timeout-minutes to 45 by youknowone · Pull Request #6541 · RustPython/RustPython

youknowone · 2025-12-26T11:34:24Z

Summary by CodeRabbit

Chores
- Standardized CI/CD pipeline timeout configuration to ensure consistent behavior across all build environments.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-26T11:34:30Z

📝 Walkthrough

Walkthrough

The CI workflow in .github/workflows/ci.yaml is updated to simplify the timeout configuration for the rust_tests job. The timeout-minutes parameter is changed from a conditional expression that varied based on the operating system to a fixed 45-minute value across all platforms.

Changes

Cohort / File(s)	Summary
CI Workflow Configuration `.github/workflows/ci.yaml`	Simplifies `rust_tests` job timeout from OS-conditional logic (varying by platform) to a fixed 45-minute timeout across all operating systems.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

CI: Increase windows timeout from 40 -> 45 #5993: Previously raised Windows timeout to 45m; this PR makes timeout fixed at 45m across all platforms.
Set timeout only on test step #6431: Refactored timeout handling by moving from job-level to per-test-step granularity; this PR maintains job-level approach with unified timeout.
Set timeout for CI #5947: Previously added conditional 40/30-minute timeouts; this PR consolidates to a single 45-minute value.

Poem

🐰 Timeout troubles now are through,
45 minutes for the crew,
No more branches, cross the board,
Swift and simple, task restored! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'increase timeout-minutes to 45' directly and clearly summarizes the main change in the pull request—modifying the timeout-minutes configuration from a conditional value to a fixed 45 minutes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9bf8df and 05f88fe.

📒 Files selected for processing (1)

.github/workflows/ci.yaml

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: ShaharNaveh
Repo: RustPython/RustPython PR: 5947
File: .github/workflows/ci.yaml:116-116
Timestamp: 2025-07-11T09:35:43.571Z
Learning: GitHub Actions timeout-minutes field supports expressions that evaluate to integers, such as `${{ contains(matrix.os, 'windows') && 40 || 30 }}`, which will conditionally set different timeout values based on the runner OS.

Learnt from: ShaharNaveh
Repo: RustPython/RustPython PR: 5947
File: .github/workflows/ci.yaml:116-116
Timestamp: 2025-07-11T09:35:43.571Z
Learning: GitHub Actions supports ternary-like expressions using `&&` and `||` operators in timeout-minutes. The syntax `${{ condition && value_if_true || value_if_false }}` is valid and commonly used, such as `${{ contains(matrix.os, 'windows') && 40 || 30 }}` which evaluates to 40 for Windows runners and 30 for others.

Learnt from: ShaharNaveh
Repo: RustPython/RustPython PR: 5932
File: .github/workflows/comment-commands.yml:18-24
Timestamp: 2025-07-10T10:08:43.330Z
Learning: In GitHub Actions workflows for the RustPython project, the maintainer ShaharNaveh prefers to keep workflows simple and doesn't mind if steps fail when the desired state is already achieved (e.g., user already assigned to an issue). Avoid suggesting complex error handling for edge cases they don't consider problematic.

📚 Learning: 2025-07-11T09:35:43.571Z

Learnt from: ShaharNaveh
Repo: RustPython/RustPython PR: 5947
File: .github/workflows/ci.yaml:116-116
Timestamp: 2025-07-11T09:35:43.571Z
Learning: GitHub Actions timeout-minutes field supports expressions that evaluate to integers, such as `${{ contains(matrix.os, 'windows') && 40 || 30 }}`, which will conditionally set different timeout values based on the runner OS.

Applied to files:

.github/workflows/ci.yaml

📚 Learning: 2025-07-11T09:35:43.571Z

Learnt from: ShaharNaveh
Repo: RustPython/RustPython PR: 5947
File: .github/workflows/ci.yaml:116-116
Timestamp: 2025-07-11T09:35:43.571Z
Learning: GitHub Actions supports ternary-like expressions using `&&` and `||` operators in timeout-minutes. The syntax `${{ condition && value_if_true || value_if_false }}` is valid and commonly used, such as `${{ contains(matrix.os, 'windows') && 40 || 30 }}` which evaluates to 40 for Windows runners and 30 for others.

Applied to files:

.github/workflows/ci.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Run rust tests (windows-latest)
GitHub Check: Run rust tests (macos-latest)
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Check Rust code with clippy
GitHub Check: Ensure compilation on various targets
GitHub Check: Check the WASM package and demo
GitHub Check: Run tests under miri

🔇 Additional comments (1)

.github/workflows/ci.yaml (1)

118-118: Timeout increased uniformly to 45 minutes for all platforms.

The change replaces the conditional timeout expression with a fixed 45-minute value, increasing the limit from 40 minutes (Windows) and 30 minutes (macOS/Linux) to 45 minutes for all platforms. This simplifies the configuration and provides adequate headroom across all runners.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

increase timeout-minutes to 45

05f88fe

youknowone marked this pull request as ready for review December 26, 2025 11:34

youknowone merged commit 72a90da into RustPython:main Dec 26, 2025
12 of 13 checks passed

youknowone deleted the ci-45 branch December 26, 2025 11:39

coderabbitai bot mentioned this pull request Jan 11, 2026

Upgrade threading to 3.13.11; sys.setprofile & impl more threading #6691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

increase timeout-minutes to 45#6541

increase timeout-minutes to 45#6541
youknowone merged 1 commit intoRustPython:mainfrom
youknowone:ci-45

youknowone commented Dec 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 26, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

youknowone commented Dec 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

youknowone commented Dec 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 26, 2025 •

edited

Loading