Move PrintExpr to IntristicFunction1#6324
Conversation
WalkthroughReplaces the specialized Changes
Sequence Diagram(s)sequenceDiagram
participant Codegen
participant Bytecode
participant VM
participant Sys as sys.displayhook
Note over Codegen,Bytecode: Compilation
Codegen->>Bytecode: emit CallIntrinsic1(Print)
Codegen->>Bytecode: emit Pop
Note over Bytecode,VM: Execution
VM->>VM: execute CallIntrinsic1(Print)
VM->>Sys: invoke displayhook(arg)
Sys-->>VM: return
VM->>VM: execute Pop (cleanup)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Implements python/cpython#100771 (partially)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.