Closed
Conversation
Contributor
|
Probably a good temporary fix. See also: #5590 |
Member
|
Since test_typing does not currently cover Self, please add a small test under |
Author
|
thanks for the feedback. i agree that #5590 is a much better approach. in our case, Self is just one of many typing blockers... |
Member
Author
|
fyi, #5711 is another blocker we ran into re: typing. Curious: is there some way we could offer to disable type checking? |
Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
Contributor
|
Closing, since other PR was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.