Skip to content

Mark version 3.13.0#5495

Merged
youknowone merged 21 commits intoRustPython:mainfrom
arihant2math:313
Feb 13, 2025
Merged

Mark version 3.13.0#5495
youknowone merged 21 commits intoRustPython:mainfrom
arihant2math:313

Conversation

@arihant2math
Copy link
Contributor

@arihant2math arihant2math commented Feb 1, 2025 •
edited
Loading

Supersedes #5482

Also:

  • Removes a difflib doctest (this can be added back during a difflib update)
  • Strips docstrings like cpython does
  • Marks some tests that got activated during 3.13 in test_enum as invalid.
  • Updates extra_tests to pass with cpython 3.13

@arihant2math arihant2math marked this pull request as ready for review February 1, 2025 00:49
@youknowone
Copy link
Member

youknowone commented Feb 1, 2025

I will immediately merge separately mergable changes like removing imghdr,sndhdr etc

@arihant2math
Copy link
Contributor Author

arihant2math commented Feb 1, 2025 •
edited
Loading

@youknowone everything works except some modules, should I disable the tests or update the modules?

@arihant2math arihant2math force-pushed the 313 branch 5 times, most recently from ebef7a1 to c8ad849 Compare February 3, 2025 19:59
@arihant2math arihant2math mentioned this pull request Feb 4, 2025
Closed
youknowone
youknowone requested changes Feb 4, 2025
View reviewed changes
youknowone
youknowone reviewed Feb 6, 2025
View reviewed changes
@youknowone youknowone mentioned this pull request Feb 6, 2025
Merged
@arihant2math
Copy link
Contributor Author

arihant2math commented Feb 6, 2025

Marking as draft as the docstring whitespace stripping isn't passing all tests.

@arihant2math arihant2math marked this pull request as draft February 6, 2025 16:45
@arihant2math arihant2math changed the title Mark version 3.13.1 Mark version 3.13.0 Feb 6, 2025
@arihant2math arihant2math force-pushed the 313 branch 2 times, most recently from ce6585a to cf95bef Compare February 11, 2025 18:34
fanninpm
fanninpm reviewed Feb 11, 2025
View reviewed changes
@arihant2math arihant2math marked this pull request as ready for review February 11, 2025 21:32
@arihant2math
Copy link
Contributor Author

arihant2math commented Feb 12, 2025

Ready for merge!

youknowone and others added 3 commits February 12, 2025 14:46
@youknowone @arihant2math
bump to 3.13.1
d3d282b 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
fix some tests
3523d6e 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
bump whats_left.py python version
1f0ea4e 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
strip left whitespace from doc
c677f22 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
fixed docstring trimming
548e1f2 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
remove specific difflib test that was causing issues
45254b2 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
fix test_enum
e4528a8 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
doc test
2a2caee 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
arihant2math and others added 13 commits February 12, 2025 16:13
@arihant2math @youknowone
Update micro version to 0
506af5e 
Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>
@arihant2math
add skips back
6dc3380 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
fix builtin_doc test
cfe5de7 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
moved tests to syntax_function2.py
3d8df6c 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
clean compile.rs and adhere to cpython implementation
962650a 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
fix doc fixing
c60c76b 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math @youknowone
fix versioning
495b103 
Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>
@arihant2math
fix subprocesses
6a09751 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
cleanup
418e11a 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math @fanninpm
Update compiler/codegen/src/compile.rs
e6f7674 
Co-authored-by: fanninpm <luxverdans@sbcglobal.net>
@arihant2math
doc space-stripping tests
07bf4a9 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
fixed tab expanding
32ef384 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
fix tests
d54b342 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
youknowone
youknowone approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@youknowone youknowone merged commit a46ce8e into RustPython:main Feb 13, 2025
11 checks passed
@arihant2math
Copy link
Contributor Author

arihant2math commented Feb 13, 2025

🎉

@arihant2math arihant2math deleted the 313 branch February 25, 2025 15:41
@youknowone youknowone mentioned this pull request Apr 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm left review comments

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arihant2math @youknowone @fanninpm