Return arg in case of invalid param in strftime#4530
Merged
youknowone merged 2 commits intoRustPython:mainfrom Feb 21, 2023
Merged
Return arg in case of invalid param in strftime#4530youknowone merged 2 commits intoRustPython:mainfrom
youknowone merged 2 commits intoRustPython:mainfrom
Conversation
Contributor
Author
|
This is re-implementation of PR: #4474 |
Chrono panics in case of unsupported formats, this patch handles such cases and returns supplied format as a result.
youknowone
requested changes
Feb 20, 2023
Member
youknowone
left a comment
There was a problem hiding this comment.
looks good except for the comment.
you don't need to open a new pr to fix branch. please ask help next time. I can help you to fix them 😄
71a8095 to
fcfe8e1
Compare
youknowone
reviewed
Feb 21, 2023
youknowone
approved these changes
Feb 21, 2023
Member
youknowone
left a comment
There was a problem hiding this comment.
Thank you for contributing!
This was referenced Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrono panics in case of unsupported formats, this patch handles such cases and returns supplied format as a result.