Open
Conversation
piranna
requested changes
Nov 17, 2017
| if [ $? -eq 0 ]; then | ||
| QEMU="$QEMU -enable-kvm" | ||
| # Check for hardware-virtualization support | ||
| if [ "$(egrep -m 1 '^flags.*(vmx|svm)' /proc/cpuinfo)" ] |
Member
There was a problem hiding this comment.
Can you check if normal grep command works instead of use egrep, and if not, change to use equivalent grep -E? Also, are the quotes needed? Isn't command expansion just enough?
| if [ "$(egrep -m 1 '^flags.*(vmx|svm)' /proc/cpuinfo)" ] | ||
| then | ||
| echo ">>> KVM: ON " | ||
| export QEMU="qemu-system-x86_64 -M accel=kvm:tcg" |
Member
There was a problem hiding this comment.
Don't use export nor set explicitly the command to be used, just reassign the QEMU environment variable like it was done before. Have you check if the -enable-kvm flag actually doesn't work on Windows? If so, have you check the -M accel=kvm:tc arguments enable KVM on Linux?
| export QEMU="qemu-system-x86_64 -M accel=kvm:tcg" | ||
| else | ||
| echo ">>> KVM: OFF " | ||
| export QEMU="qemu-system-i386" |
Member
There was a problem hiding this comment.
Remove this else branch, or at least the assignation of the QEMU variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using mingw (or even the bash that comes with git-scm), and the windows build of QEMU gets us right up to the point of running NodeOS, but the original
qemu.shscript doesn't detect KVM in a way that allows Windows to launch it, instead complaining about no accelerator detected.The patch borrows from lrvick/airgap#3 to circumvent this error. Working on windows 10 with the
v2.10build of QEMU.