first attempt to add nodeos-standard to NodeOS#294
Open
TylerLeonhardt wants to merge 5 commits intoNodeOS:masterfrom
Open
first attempt to add nodeos-standard to NodeOS#294TylerLeonhardt wants to merge 5 commits intoNodeOS:masterfrom
TylerLeonhardt wants to merge 5 commits intoNodeOS:masterfrom
Conversation
Member
|
@tylerl0706 I suggest you drop the camelCase name in favor of a dash.
Using dashes avoids case sensitivity issues on Windows and Linux and is more inline with common Node conventions. |
Contributor
Author
|
@aulvi done :) |
Contributor
Author
|
@piranna: can you take a look at why this failed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So all the important stuff is in the package.json
We're using nodeos-standard 0.2.0 which includes allman style.
You'll notice the command:
"csCheck": "nodeos-standard $(grep -ril './scripts' -e '/usr/bin/env node') ; exit 0"This does a few things...it grabs all the files in the scripts folder that are to be run with Node assuming that they are javascript... This was needed because ESLint tried to give feedback on bash scripts... lol
the
; exit 0at the end ensures that the script is purely informative and doesn't crash the whole execution of whatever it's doing.I added
npm run csCheckto the end ofnpm testas I figured the tests can run and than the code style can be checked.Let me know what you think!
We'd do something like this in every NodeOS repo.
Cheers!