feat: introduce PageService#2111
Merged
vakrilov merged 2 commits intoNativeScript:masterfrom Jan 31, 2020
Merged
Conversation
Contributor
|
test |
vakrilov
previously approved these changes
Jan 30, 2020
Contributor
There was a problem hiding this comment.
Awesome work @edusperoni !
Nice improvements in the page-router-outlet code as well.
Only small change request - can you change Destruct<a>ble to Destruct<i>ble
Collaborator
Author
|
Oops! Fixed it now! |
vakrilov
approved these changes
Jan 30, 2020
Contributor
|
Triggering internal CI |
Contributor
|
test |
|
@edusperoni Is this still part of the latest |
Collaborator
Author
|
It seems it was removed in some cleanup. For the moment you can copy the code and put the class in the providers for your component, it should work without an issue. |
|
@edusperoni Thanks for checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
To detect navigation we have to manually inject page, listen to events and handle the subscriptions.
What is the new behavior?
Introduces a
PageServicethat has:page: reference to the current pageinPage: boolean: Page is the currently displayed pageinPage$: Observable<boolean>: will emit true/false when entering/leaving pagepageEvents$: Observable<NavigatedData>: observable of page events (use withfilteroperator)example implementation:
The "RxJs way":
Provides an "angular way" of managing #374