Skip to content

fix(ios-actionbar): parent/child gesture recognition#7400

Merged
manoldonev merged 3 commits intomasterfrom
mdonev/master-detail-fix
Jun 26, 2019
Merged

fix(ios-actionbar): parent/child gesture recognition#7400
manoldonev merged 3 commits intomasterfrom
mdonev/master-detail-fix

Conversation

@manoldonev
Copy link
Contributor

@manoldonev manoldonev commented Jun 24, 2019

Changes related to parent/child gesture recognition in iOS introduced with #7296 break an ActionBar usage scenario in all master/detail templates here:

    <ActionBar class="action-bar">
       ...

        <ActionItem ios.position="right" android.position="right">
            <Label text="Done" class="action-item" verticalAlignment="center" tap="onDoneButtonTap" 
                isEnabled="{{ car.isModelValid }}"
                isUserInteractionEnabled="{{ car.isModelValid }}" />
        </ActionItem>
    </ActionBar>

Where tap event is not raised for the ActionItem Label anymore.

@manoldonev manoldonev self-assigned this Jun 24, 2019
@cla-bot cla-bot bot added the cla: yes label Jun 24, 2019
@manoldonev manoldonev mentioned this pull request Jun 24, 2019
Merged
5 tasks
@MCurran16
Copy link
Contributor

MCurran16 commented Jun 24, 2019

:(

@manoldonev manoldonev merged commit 8722075 into master Jun 26, 2019
@manoldonev manoldonev deleted the mdonev/master-detail-fix branch June 26, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@manoldonev manoldonev

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manoldonev @MCurran16