chore(core): now the ui-mobile-widgets is directly provided as sources#10896
Open
farfromrefug wants to merge 1 commit intoNativeScript:mainfrom
Open
chore(core): now the ui-mobile-widgets is directly provided as sources#10896farfromrefug wants to merge 1 commit intoNativeScript:mainfrom
farfromrefug wants to merge 1 commit intoNativeScript:mainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 2d92115
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
ui-mobile-basepackages directly provided as source code inside@nativescript/core@nativescript/coreanymore => smaller npm package@nativescript/core=>@nativescript/corebuild does not need to be done on macos anymore (maybe only better for testing). Also even a macos intel can build now and does not need visionos sdk (not available on intel)ui-mobile-basecode directlyui-mobile-basedirectly with xcode and android studio in their appui-mobile-baseto ensure it builds, or use a native test appui-mobile-basesource code is now built with app dependencies for androidx, ... => uniformity, easy upgrade to latest SDks, java, ...