chore(deps): update dependency cryptography to v46#13831
chore(deps): update dependency cryptography to v46#13831renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the process of keeping project dependencies up-to-date by upgrading the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the cryptography dependency from version 45.0.1 to 46.0.5. This is a major version update which drops support for Python 3.7.
I've added comments to the requirements.txt files to suggest pinning cryptography conditionally based on the Python version. This will prevent breaking the setup for users on Python 3.7, which appears to be supported based on other conditional dependencies in the project.
| @@ -1,4 +1,4 @@ | |||
| cryptography==45.0.1 | |||
| cryptography==46.0.5 | |||
There was a problem hiding this comment.
The updated cryptography version 46.x drops support for Python 3.7. To maintain compatibility for projects using Python 3.7 (as suggested by the conditional pem dependency), you should specify cryptography versions conditionally based on the Python version. This will ensure that a compatible version of cryptography is used for Python 3.7 environments.
cryptography==45.0.1; python_version < '3.8'
cryptography==46.0.5; python_version >= '3.8'
| @@ -1,4 +1,4 @@ | |||
| google-cloud-kms==3.2.1 | |||
| cryptography==45.0.1 | |||
| cryptography==46.0.5 | |||
There was a problem hiding this comment.
The updated cryptography version 46.x drops support for Python 3.7. To avoid breaking environments using Python 3.7, you should specify cryptography versions conditionally. This ensures that projects relying on Python 3.7 do not fail during dependency installation.
cryptography==45.0.1; python_version < '3.8'
cryptography==46.0.5; python_version >= '3.8'
| pytest==8.2.0 | ||
| google-auth==2.38.0 | ||
| cryptography==45.0.1 | ||
| cryptography==46.0.5 |
There was a problem hiding this comment.
The updated cryptography version 46.x drops support for Python 3.7. To avoid breaking test environments using Python 3.7, you should specify cryptography versions conditionally. This will ensure the test suite can run on older supported Python versions without installation issues.
cryptography==45.0.1; python_version < '3.8'
cryptography==46.0.5; python_version >= '3.8'
This PR contains the following updates:
==45.0.1→==46.0.5Release Notes
pyca/cryptography (cryptography)
v46.0.5Compare Source
v46.0.4Compare Source
v46.0.3Compare Source
v46.0.2Compare Source
v46.0.1Compare Source
v46.0.0Compare Source
v45.0.7Compare Source
v45.0.6Compare Source
v45.0.5Compare Source
v45.0.4Compare Source
v45.0.3Compare Source
v45.0.2Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.