Update types for @types/dom-navigation#74469
Update types for @types/dom-navigation#74469jeffydc wants to merge 1 commit intoDefinitelyTyped:masterfrom
@types/dom-navigation#74469Conversation
dom-navigationdom-navigation
|
@jeffydc Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 7 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74469,
"author": "jeffydc",
"headCommitOid": "79e4c21d974b02e677875056cf116ccf9c146c7d",
"mergeBaseOid": "982edf5d9655b7eca3825d113f90ebdbed4aaa39",
"lastPushDate": "2026-02-04T16:30:52.000Z",
"lastActivityDate": "2026-02-08T06:28:11.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "dom-navigation",
"kind": "edit",
"files": [
{
"path": "types/dom-navigation/dom-navigation-tests.ts",
"kind": "test"
},
{
"path": "types/dom-navigation/index.d.ts",
"kind": "definition"
},
{
"path": "types/dom-navigation/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/dom-navigation/ts5.7/dom-navigation-tests.ts",
"kind": "test"
},
{
"path": "types/dom-navigation/ts5.7/index.d.ts",
"kind": "definition"
},
{
"path": "types/dom-navigation/ts5.7/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"tbondwilkinson"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "atscott",
"date": "2026-02-06T22:09:02.000Z",
"abbrOid": "fc96919"
}
],
"mainBotCommentID": 3848471382,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/79e4c21d974b02e677875056cf116ccf9c146c7d/checks?check_suite_id=56746533062"
} |
|
🔔 @tbondwilkinson — please review this PR in the next few days. Be sure to explicitly select |
dom-navigationdom-navigation
dom-navigation@types/dom-navigation] Update types for dom-navigation
|
@jeffydc The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
@types/dom-navigation] Update types for dom-navigation@types/dom-navigation
types/dom-navigation/index.d.ts
Outdated
| readonly finished: Promise<void>; | ||
| } | ||
|
|
||
| // declare class NavigationActivation { |
There was a problem hiding this comment.
I need a guidance on how shall we proceed for this type?
NavigationActivation does not exist until TS 5.8.
Shall we use typesVersion for this or bump the TS version requirement?
There was a problem hiding this comment.
I think we need to use typesVersion based on the current support window, which requires that this package support TS 5.4 and not force an update to 5.8.
Maybe move the activation property addition to a separate change? Everything else in this LGTM
There was a problem hiding this comment.
Thanks. I have updated the changes.
It seems TS 6.0 nightly contains the Navigation API so the CI is failing.
So I used typesVersion again for TS 5.9, but then I am not sure what should go into index.d.ts in the package root. Linting is failing if I keep empty index.d.ts file.
|
according to [npmjs.org](https://www.npmjs.com/package/dom-navigation], dom-navigation contains malicious code and was removed from the registry by the npm security team so i am a little bit concerned about downloading and testing it |
|
@jeffydc The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
|
CI wrong |
types/dom-navigation/index.d.ts
Outdated
| readonly finished: Promise<void>; | ||
| } | ||
|
|
||
| // declare class NavigationActivation { |
There was a problem hiding this comment.
I think we need to use typesVersion based on the current support window, which requires that this package support TS 5.4 and not force an update to 5.8.
Maybe move the activation property addition to a separate change? Everything else in this LGTM
|
@jeffydc One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
fc96919 to
79e4c21
Compare
|
@jeffydc The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
This PR updates the types of dom-navigation to match with the latest spec.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.