Fix transient minio startup timeout in CI#96993
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 15, 2026
Merged
Conversation
The `setup_minio.sh` script is started asynchronously, and the Python poller checks `mc ls clickminio/test` to detect readiness. With only 20 retries (~40s total including command execution time), the timeout is insufficient when minio is slow to start. The shell script's `start_minio` function had an unnecessary `sleep 5` after `wait_for_it` already confirmed the server is responsive, wasting 5 seconds. The 20-retry limit in the Python poller was too tight given that `wait_for_it` alone can take up to 60 seconds. Changes: - Remove unnecessary `sleep 5` from `start_minio` in `setup_minio.sh` - Increase the polling retry count from 20 to 60 in `clickhouse_proc.py` https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=96987&sha=eb763d8476e10cd6b9c1161babaf23376002dbe8&name_0=PR&name_1=Stateless%20tests%20%28amd_debug%2C%20AsyncInsert%2C%20s3%20storage%2C%20sequential%29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a transient CI failure where minio infrastructure setup times out before tests can run, observed in "Stateless tests (amd_debug, AsyncInsert, s3 storage, sequential)".
sleep 5insetup_minio.shafterwait_for_italready confirmed minio is responsiveclickhouse_proc.pyObservations from the failure
CI report
The job failed at
Start ClickHouse ServerwithFailed to start minio. Zero tests executed.setup_minio.shis launched asynchronously and the Python poller immediately starts checkingmc ls clickminio/test | grep -q .every ~2s (1s sleep + ~1s for the failing command). With 20 retries this gives a ~40s total budget.Timeline from the job log:
setup_minio.shstarted, polling beginsmcerrors withRequested path .../clickminio not found— themcalias hasn't been configured yet, meaning minio server startup + thesleep 5consumed all this timeBucket test does not exist— alias is now set butmc mb clickminio/testhasn't completedFailed to start minioThe
setup_minio.shexecution sequence is: start minio server →wait_for_it(up to 60s) →lsof→sleep 5→mc alias set→mc mb→mc cpdata. Thesleep 5afterwait_for_italready confirmed responsiveness is wasteful, and the 20-retry budget (~40s) cannot accommodate even thewait_for_itworst case (60s).Test plan
setup_minio.shor the polling logicChangelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
🤖 Generated with Claude Code