Skip to content

[ts] Enforce order for the override modifier#13209

Merged
nicolo-ribaudo merged 4 commits intobabel:feat-7.14.0/parser-updatesfrom
nicolo-ribaudo:override-order
Apr 27, 2021
Merged

[ts] Enforce order for the override modifier#13209
nicolo-ribaudo merged 4 commits intobabel:feat-7.14.0/parser-updatesfrom
nicolo-ribaudo:override-order

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 26, 2021

Q                       A
Fixed Issues? Ref: microsoft/TypeScript#43660
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: parser area: typescript labels Apr 26, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 26, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45621/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a11b53d:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this PR also introduce static override support?

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Apr 26, 2021

I need to update this PR for microsoft/TypeScript#43829

Did this PR also introduce static override support?

Yes 👍

@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.14.0/parser-updates branch from a9f5e07 to 3c7aeb3 Compare April 26, 2021 20:31
@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Apr 26, 2021

CI caught a regression closely related to a TS bug I just found: microsoft/TypeScript#43836. I will only fix the regression partially, and wait for the TS bug to be fixed to understand what is the expected behavior.

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Apr 26, 2021

Oh it's not a regression, it's a bugfix lol

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Apr 26, 2021

The new tests in the allowlist are not related to this PR, they are just new TS tests.

@nicolo-ribaudo nicolo-ribaudo merged commit 52a59b1 into babel:feat-7.14.0/parser-updates Apr 27, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the override-order branch April 27, 2021 20:51
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 28, 2021
Merged
9 tasks
nicolo-ribaudo added a commit that referenced this pull request Apr 28, 2021
@nicolo-ribaudo
[ts] Enforce order for the override modifier (#13209)
22b0eb0 
* [ts] Enforce order for the `override` modifier

* generator

* Add more checks

* Update TS tests
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 30, 2021
Closed
1 task
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolo-ribaudo @babel-bot @existentialism @JLHwung @kaicataldo

Comments