Add AzuriteContainer to Azure module#9661
Merged
eddumelendez merged 13 commits intotestcontainers:mainfrom Jan 9, 2025
Merged
Conversation
- Add AzuriteContainer to Azure module - Implement new tests - Update Azure documentation Signed-off-by: Esta Nagy <nagyesta@gmail.com>
eddumelendez
requested changes
Dec 19, 2024
Member
eddumelendez
left a comment
There was a problem hiding this comment.
Hi, thanks for your contribution. I've left comments.
modules/azure/src/main/java/org/testcontainers/containers/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/containers/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/containers/AzuriteConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/containers/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/containers/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/containers/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/containers/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
- Move Azurite container to Azure specific package - Move Connection String builder to AzuriteContainer - Remove unnecessary configuration options - Add tests for SSL configuration - Remove duplications and unnecessary details from Azure module documentation Signed-off-by: Esta Nagy <nagyesta@gmail.com>
- Remove unnecessary comment Signed-off-by: Esta Nagy <nagyesta@gmail.com>
- Fix note formatting Signed-off-by: Esta Nagy <nagyesta@gmail.com>
- Use AssertJ in tests Signed-off-by: Esta Nagy <nagyesta@gmail.com>
- Fix configuration issue (to allow connections from any IP) Signed-off-by: Esta Nagy <nagyesta@gmail.com>
- Fix formatting Signed-off-by: Esta Nagy <nagyesta@gmail.com>
eddumelendez
requested changes
Dec 23, 2024
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzuriteContainer.java
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
- Fix code review findings Signed-off-by: Esta Nagy <nagyesta@gmail.com>
eddumelendez
reviewed
Jan 6, 2025
modules/azure/src/main/java/org/testcontainers/azure/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzuriteContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzuriteContainerTest.java
Outdated
Show resolved
Hide resolved
- Fix code review findings Signed-off-by: Esta Nagy <nagyesta@gmail.com>
- Remove host configuration Signed-off-by: Esta Nagy <nagyesta@gmail.com>
- Remove unused constant Signed-off-by: Esta Nagy <nagyesta@gmail.com>
- Add test cases and examples for non-default credential use Signed-off-by: Esta Nagy <nagyesta@gmail.com>
Member
|
Thanks for your contribution, @nagyesta! |
Contributor
Author
|
Thank you @eddumelendez ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #9607