Conversation
Member
|
Thanks very much @altesse for this PR (even including a test!), which has now been merged. Future contributions are most welcome. |
Contributor
Author
|
Thanks to you! I'll try to improve the test as soon as I can. Interested in
contributing, to the extent of my modest abilities.
Le lun. 17 déc. 2018 à 00:29, Ben Alex <notifications@github.com> a écrit :
… Thanks very much @altesse <https://github.com/altesse> for this PR (even
including a test!), which has now been merged. Future contributions are
most welcome.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#112 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGDNN1XVn2_w95QkeByA7R7mHDKdrddmks5u5tc8gaJpZM4ZNWvE>
.
|
Member
The current test is fine. Thanks for having provided it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See request #104 , we would like to be able to set map size on an open Env.