[rustls] remove legacy rustls 0.21 from our code. #5631
Description
We want to remove legacy rustls 0.21 from our code.
Pulling the legacy rustls increases our binary size and wastes compilation time and resources.
It is not fips compatible and uses legacy ring cryptography module.
See note about changes to the default HTTPS client stack awslabs/aws-sdk-rust#1257
Most of the legacy users in our code were updated and we switched to modern rustls 0.23
See #5556
We still use iceberg-glue-catalog that pulls absolute rustls 0.21 as it depends on aws-sdk-glue/aws-sdk-s3tables which bring legacy rustls for compatibility. It is up to iceberg-rust maintainers to update their Cargo.toml files with proper features of aws-sdk-glue/aws-sdk-s3tables crates.
I made a PR for iceberg-rust crate to use aws-sdk-glue/aws-sdk-s3tables with a default-https-client and avoid pulling legacy rustls 0.21, see apache/iceberg-rust#2104
Once iceberg-rust merges this PR and iceberg-rust makes a release then we just have to update iceberg-rust (i think it is only iceberg-of this issue just has to update iceberg modules in our cargo files.
To Reproduce
nfnnln@Nfns-MacBook-Pro feldera_igorsc_remote % cargo tree --workspace --all-features --target all -i rustls@0.21
rustls v0.21.12
├── aws-smithy-http-client v1.1.9
│ └── aws-smithy-runtime v1.10.0
│ ├── aws-config v1.8.13
│ │ ├── aws-msk-iam-sasl-signer v1.0.1
│ │ │ └── dbsp_adapters v0.244.0 (/Users/nfnnln/src/feldera/feldera_igorsc_remote/crates/adapters)
│ │ ├── dbsp_adapters v0.244.0 (/Users/nfnnln/src/feldera/feldera_igorsc_remote/crates/adapters)
│ │ ├── deltalake-aws v0.9.1 (https://github.com/ryzhyk/delta-rs.git?rev=06f42db5344f4ad8560af341352572488a4e6e06#06f42db5)
│ │ │ ├── deltalake v0.26.2 (https://github.com/ryzhyk/delta-rs.git?rev=06f42db5344f4ad8560af341352572488a4e6e06#06f42db5)
│ │ │ │ └── dbsp_adapters v0.244.0 (/Users/nfnnln/src/feldera/feldera_igorsc_remote/crates/adapters)
│ │ │ └── deltalake-catalog-unity v0.10.1 (https://github.com/ryzhyk/delta-rs.git?rev=06f42db5344f4ad8560af341352572488a4e6e06#06f42db5)
│ │ │ ├── dbsp_adapters v0.244.0 (/Users/nfnnln/src/feldera/feldera_igorsc_remote/crates/adapters)
│ │ │ └── deltalake v0.26.2 (https://github.com/ryzhyk/delta-rs.git?rev=06f42db5344f4ad8560af341352572488a4e6e06#06f42db5) (*)
│ │ └── iceberg-catalog-glue v0.5.1
│ │ └── feldera-iceberg v0.244.0 (/Users/nfnnln/src/feldera/feldera_igorsc_remote/crates/iceberg)
│ │ └── dbsp_adapters v0.244.0 (/Users/nfnnln/src/feldera/feldera_igorsc_remote/crates/adapters)
│ ├── aws-runtime v1.6.0
│ │ ├── aws-config v1.8.13 (*)
│ │ ├── aws-sdk-dynamodb v1.78.0
│ │ │ └── deltalake-aws v0.9.1 (https://github.com/ryzhyk/delta-rs.git?rev=06f42db5344f4ad8560af341352572488a4e6e06#06f42db5) (*)
│ │ ├── aws-sdk-glue v1.98.0
│ │ │ └── iceberg-catalog-glue v0.5.1 (*)
│ │ ├── aws-sdk-s3 v1.122.0
│ │ │ └── dbsp_adapters v0.244.0 (/Users/nfnnln/src/feldera/feldera_igorsc_remote/crates/adapters)
│ │ ├── aws-sdk-sso v1.93.0
│ │ │ └── aws-config v1.8.13 (*)
│ │ ├── aws-sdk-ssooidc v1.95.0
│ │ │ └── aws-config v1.8.13 (*)
│ │ └── aws-sdk-sts v1.97.0
│ │ ├── aws-config v1.8.13 (*)
│ │ ├── aws-msk-iam-sasl-signer v1.0.1 (*)
│ │ └── deltalake-aws v0.9.1 (https://github.com/ryzhyk/delta-rs.git?rev=06f42db5344f4ad8560af341352572488a4e6e06#06f42db5) (*)
│ ├── aws-sdk-dynamodb v1.78.0 (*)
│ ├── aws-sdk-glue v1.98.0 (*)
│ ├── aws-sdk-s3 v1.122.0 (*)
│ ├── aws-sdk-sso v1.93.0 (*)
│ ├── aws-sdk-ssooidc v1.95.0 (*)
│ └── aws-sdk-sts v1.97.0 (*)
├── hyper-rustls v0.24.2
│ └── aws-smithy-http-client v1.1.9 (*)
└── tokio-rustls v0.24.1
└── hyper-rustls v0.24.2 (*)
nfnnln@Nfns-MacBook-Pro feldera_igorsc_remote %
Expected behavior
nfnnln@Nfns-MacBook-Pro feldera_igorsc_remote % cargo tree --workspace --all-features --target all -i rustls@0.21
error: package ID specification `rustls@0.21` did not match any packages
help: there are similar package ID specifications:
rustls@0.23.36
nfnnln@Nfns-MacBook-Pro feldera_igorsc_remote %
Screenshots
Context (please complete the following information):
- Feldera Version:
- Environment:
- Browser:
- Pipeline Configuration/SQL code:
Additional context
Add any other context about the problem here.